Skip to content

bugfix/FOUR-27646 First Financial Bank - Validation Rules for Hidden Required Fields Inside Loops Are Inconsistently Applied #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavobascope wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −3
Open

bugfix/FOUR-27646 First Financial Bank - Validation Rules for Hidden Required Fields Inside Loops Are Inconsistently Applied #1913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/ValidationsFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class FormLoopValidations extends Validations {
return;
}
page.items.filter(item => {
if (item.component === 'FormLoop' && item.config.name === this.element.config.name) {
if (item.component === 'FormLoop' && item.config.name === this.element.config.name && item !== this.element) {
siblings.push(item);
}
});
Expand Down Expand Up @@ -240,8 +240,10 @@ class PageNavigateValidations extends Validations {
*/
class FormElementValidations extends Validations {
async addValidations(validations) {
// Disable validations if field is hidden
if (!this.isVisible()) {
// When inside a loop, each row may have different data so the static isVisible()
// check (which uses only the first row's data) cannot reliably determine visibility.
// The runtime closure evaluates conditionalHide per-row with the correct data.
if (!this.insideLoop && !this.isVisible()) {
return;
}
if (this.element.config && this.element.config.readonly) {
Expand Down
Loading