FOUR-26712 Implement the Events and Logic in Backed for Conditional Destination#8540
Merged
caleeli merged 4 commits intofeature/FOUR-26707from Sep 26, 2025
Merged
FOUR-26712 Implement the Events and Logic in Backed for Conditional Destination#8540caleeli merged 4 commits intofeature/FOUR-26707from
caleeli merged 4 commits intofeature/FOUR-26707from
Conversation
rodriquelca
approved these changes
Sep 26, 2025
rodriquelca
reviewed
Sep 26, 2025
|
|
||
| $this->feel->setBody($condition); | ||
| try { | ||
| $result = ($this->feel)($data); |
Contributor
There was a problem hiding this comment.
a new instance is created for everi conditions, if we have 10 then then instances will be created
Contributor
Author
There was a problem hiding this comment.
$this->feel callable is created once in the constructor, at this line to get the reference of the callable I had to use ($this->feel) to avoid confution with normal functions, but it is not creating a new instance for each condition.
rodriquelca
reviewed
Sep 26, 2025
|
rodriquelca
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Events and Logic in Backed for Conditional Destination
Related Tickets & Packages