Skip to content

chore: bump version to 0.6.4 and update pre-commit configuration#88

Merged
qjrm1430 merged 3 commits into
mainfrom
fix--pre-commit-n-workflow-fix
May 7, 2026
Merged

chore: bump version to 0.6.4 and update pre-commit configuration#88
qjrm1430 merged 3 commits into
mainfrom
fix--pre-commit-n-workflow-fix

Conversation

@qjrm1430
Copy link
Copy Markdown
Member

@qjrm1430 qjrm1430 commented May 7, 2026

🚀 PR Type (Required)

Select one and delete the others:

  • 🎯 Ready for Review - All quality checks passed, ready for merge
  • 🔄 Draft/WIP - Early feedback welcome (tests/docs may be incomplete)
  • ⚡ Quick Fix - Urgent fix requiring expedited review

Proact0 Culture: We value early collaboration! Draft PRs are encouraged for complex changes.


📝 Summary

📄 Description

🔗 Issue / Dependencies / Mentions

  • Issue:
  • Dependencies:
  • SNS handle:

💪 Ownership (Required)

  • Hand-raise: I will monitor the impact of this change and take responsibility for follow-up issues

Extreme Ownership: At Proact0, we track not just code changes, but their impact on team productivity.

✅ Quality Checks (Required for "Ready for Review" only)

  • uv run ruff check . passed
  • uv run pytest -q passed

Draft/WIP PRs: Skip quality checks for early feedback - just mark as Draft!

💡 Notes (Optional)

🔗 Related Issue(s)

@qjrm1430 qjrm1430 self-assigned this May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 0.6.4 and includes several maintenance changes to the scaffolded project, such as updating CI workflows, refining Ruff linting configurations, and cleaning up code formatting. Feedback highlights a version inconsistency in the pyproject.toml file, a recommendation to use 'extend-exclude' in the Ruff configuration to maintain default exclusions, and a request to translate Korean comments in the pre-commit configuration to English for consistency.

Comment thread act_operator/act_operator/scaffold/{{ cookiecutter.act_slug }}/pyproject.toml Outdated
Comment thread act_operator/act_operator/scaffold/{{ cookiecutter.act_slug }}/pyproject.toml Outdated
rev: v0.12.0
hooks:
- id: ruff-check
# 코드 품질 점검 및 임포트 정리
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comments in this configuration file are in Korean, while the rest of the project (including docstrings and scripts) is in English. For consistency and better maintainability in an English-primary environment, it is recommended to use English for all comments.

        # Code quality check and import sorting

types_or: [python, pyi]
args: [--fix]
- id: ruff-format
# 코드 포맷팅
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comments in this configuration file are in Korean, while the rest of the project is in English. It is recommended to use English for consistency.

        # Code formatting

qjrm1430 and others added 2 commits May 7, 2026 16:43
…/pyproject.toml

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…/pyproject.toml

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qjrm1430 qjrm1430 merged commit c63a8ea into main May 7, 2026
3 checks passed
@qjrm1430 qjrm1430 deleted the fix--pre-commit-n-workflow-fix branch May 7, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant