Skip to content

Fix 19hz and main site localStorage cache key collision#68

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/distinct-cache-implementation
Closed

Fix 19hz and main site localStorage cache key collision#68
Copilot wants to merge 2 commits intomainfrom
copilot/distinct-cache-implementation

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Both map.js and 19hz/map.js use the same localStorage keys (events, events_age), causing them to overwrite each other's cached event data since both are served from the same origin.

Changes

  • 19hz/map.js: Rename localStorage keys from events/events_age to 19hz_events/19hz_events_age
// Before (collides with root map.js)
window.localStorage.getItem('events')
window.localStorage.setItem('events_age', Date.now())

// After
window.localStorage.getItem('19hz_events')
window.localStorage.setItem('19hz_events_age', Date.now())

Root map.js keys are unchanged.

Original prompt

19hz cache and regular site cache are clobbering each other please use distinct caches


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix cache clobbering between 19hz and regular site caches Fix 19hz and main site localStorage cache key collision Mar 19, 2026
Copilot AI requested a review from ProLoser March 19, 2026 07:07
@ProLoser ProLoser closed this Mar 19, 2026
@ProLoser ProLoser deleted the copilot/distinct-cache-implementation branch March 19, 2026 07:07
@github-actions
Copy link

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-19 07:07 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants