Add Firebase validation rules and client-side guards for user name and avatar URL#196
Draft
Add Firebase validation rules and client-side guards for user name and avatar URL#196
Conversation
Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com> Agent-Logs-Url: https://github.com/ProLoser/PeaceInTheMiddleEast/sessions/acb4c0b6-0597-4151-b2ad-467b718b7c37
Copilot
AI
changed the title
[WIP] Add Firebase protection to prevent abusive names or avatar URLs
Add Firebase validation rules and client-side guards for user name and avatar URL
Mar 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users could write arbitrary strings as display names or any URL (including
javascript:,http:, or malformed) as avatar URLs directly to the Realtime Database.Firebase Database Rules (
database.rules.json)Field-level
.validaterules added tousers/$uid:namephotoURL/^https:\/\/\S+/), max 500 chars; deletion alloweduid$uid(prevents spoofing)search/languagefcmToken/fcmTokens$otherfalse— blocks arbitrary field injectionClient-side (
Profile.tsx)validateProfile()runs the same constraints before any Firebase write, surfacing a human-readable error inlinemaxLengthattributes on inputs; photoURL placeholder updated tohttps://CSS (
Profile.css).profile-errorstyled via--error-colorCSS variable (fallback#d32f2f)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.