Skip to content

Fix move animation clipping beneath board border #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 10 commits into
base: main
Choose a base branch
from
+8 −5
Open

Fix move animation clipping beneath board border #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f33bf3
Initial plan
Copilot Mar 20, 2026
34f9f73
fix: extend animation overlay over board border, fix z-index layering
Copilot Mar 20, 2026
592e9ad
fix: revert inset/JS, drop overflow:hidden to fix piece clipping at b…
Copilot Mar 21, 2026
cad0af6
fix: move overlay last in DOM for paint order, clip at board edge, ra…
Copilot Mar 21, 2026
5ff2963
fix: raise overlay z-index to 10 so animated pieces render above boar…
Copilot Mar 22, 2026
26dbae4
fix: expand overlay to board border-box so animated pieces paint over…
Copilot Mar 22, 2026
0f9093a
Merge branch 'main' into copilot/fix-animation-position
ProLoser Mar 22, 2026
87a2b4f
Update src/Board/MoveAnimation.css
ProLoser Mar 22, 2026
f7bcc02
revert: restore borderWidth offset in overlay coordinate origin
Copilot Mar 22, 2026
cc12102
fix: sample piece size from .point only, not bar pieces
Copilot Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Board/Board.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
--secondary-hover: rgb(128, 128, 211);
--valid: greenyellow;
--highlight: red;
--board-border: 5vmin;
user-select: none;
position: relative;
display: grid;
Expand All @@ -13,7 +14,7 @@
height: 100%;
width: 100%;
touch-action: none;
border: 5vmin solid #aaa;
border: var(--board-border) solid #aaa;
transition: border-color 1s;
box-sizing: border-box;
.selected {
Expand Down
4 changes: 3 additions & 1 deletion src/Board/MoveAnimation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
.move-animation-overlay {
position: absolute;
inset: 0;
inset: calc(-1 * var(--board-border, 5vmin));
Comment thread
ProLoser marked this conversation as resolved.
width: auto;
height: auto;
pointer-events: none;
z-index: 10;
overflow: hidden;
Expand Down
2 changes: 1 addition & 1 deletion src/Board/MoveAnimation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function MoveAnimation({ pairs, boardRef }: MoveAnimationProps) {
const points = board.querySelectorAll<HTMLElement>('.point');
const bars = board.querySelectorAll<HTMLElement>('.bar');

const samplePiece = board.querySelector<HTMLElement>('.piece:not(.ghost):not(.moved) img');
const samplePiece = board.querySelector<HTMLElement>('.point .piece:not(.ghost):not(.moved) img');
const pieceSize = samplePiece
? samplePiece.getBoundingClientRect().width
: boardRect.width / 17;
Expand Down
2 changes: 1 addition & 1 deletion src/Dialogues/Dialogues.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dialog {
z-index: 1;
z-index: 100;
background: var(--dialog-background-color);
color: var(--primary-color);
backdrop-filter: blur(10px);
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ export function App() {
pulsate={isMyTurn && game.status === Status.Rolling}
undo={!!match && isMyTurn && usedDice.length > 0 && usedDice.length < game.dice.length}
/>
<MoveAnimation pairs={movePairs} boardRef={boardRef} />
<div className={classes('bar', {
selected: selected === -1 && game.color === Color.White,
valid: game.color === Color.White && game.prison?.white > 0 && sources.has(-1)
Expand Down Expand Up @@ -537,6 +536,7 @@ export function App() {
moved={lastMove.moved[index]}
/>
)}
<MoveAnimation pairs={movePairs} boardRef={boardRef} />
</div>
</Dialogues>
);
Expand Down
Loading