fix: cache GitHub API responses for compare endpoint to avoid rate limiting#2872
Open
Tanisha-sharma7302 wants to merge 1 commit into
Open
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2841
Problem
The
/api/metrics/compareendpoint had a TTL reserved for it inmetrics-cache.ts(
compare: 30 * 60) but never actually used it — instead it relied on a customSupabase-based cache keyed per viewer + target user + calendar day. This meant
every new (viewer, target, day) combination triggered 4-5 fresh GitHub API calls
with no short-term caching, contributing to rate-limit (403) responses under
repeated/rapid dashboard usage as described in the issue.
Fix
Switched the compare endpoint to use the existing
withMetricsCache-styleRedis/memory caching system (
cacheGet/cacheSetfrommetrics-cache.ts),using the already-reserved 30-minute TTL — consistent with every other metrics
endpoint in the app. Also respects the existing
?refresh=true/?bypassCache=truecache-bypass convention.Testing
pnpm run type-checkpasses with no errorspnpm vitest run) unaffected