test : exported digest-email helpers and added unit tests#2817
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : exported digest-email helpers and added unit tests#2817tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2812.
Summary of What Has Been Done: Created test/digest-email.test.ts with 25 test cases covering esc, pluralise, and langColour. Also exported these helpers from src/lib/digest-email.ts and added a String() coercion to esc to handle non-string inputs safely.
Changes Made:
Impact it Made: esc is a critical XSS sanitiser for the weekly digest email. Making it defensive (coerces non-string to string) prevents crashes and hardens the email template against unexpected input types.