Skip to content

fix: correct type error in themes test (pass ThemeId not ThemeDefinition)#2705

Closed
tmdeveloper007 wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#2699-fix
Closed

fix: correct type error in themes test (pass ThemeId not ThemeDefinition)#2705
tmdeveloper007 wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#2699-fix

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Closes #2699.

Summary of What Has Been Done: Fixed a TypeScript error in test/themes.test.ts where the getThemeDefinition test was passing a ThemeDefinition object instead of a ThemeId to the function under test. This caused a TS2345 type error in the CI type-check step.

Changes Made:

  • test/themes.test.ts: Fixed getThemeDefinition test to pass theme.id (ThemeId) instead of theme (ThemeDefinition)
  • test/themes.test.ts: Fixed nextThemeId invalid-input test to use as ThemeId cast
  • Added import for ThemeId type for type casting in tests

Impact it Made: Resolves the CI failure on PR #2704. All other checks (Lint, CodeQL, Build, etc.) passed; only the type-check step failed.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts) labels Jun 22, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Umbrella-io — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Branch has conflicts with main due to the themes test file being updated after this PR was opened. Please rebase onto main and resolve conflicts — the fix itself is correct and needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for themes utilities

2 participants