fix: correct type error in themes test (pass ThemeId not ThemeDefinition)#2705
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix: correct type error in themes test (pass ThemeId not ThemeDefinition)#2705tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
Branch has conflicts with main due to the themes test file being updated after this PR was opened. Please rebase onto main and resolve conflicts — the fix itself is correct and needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2699.
Summary of What Has Been Done: Fixed a TypeScript error in test/themes.test.ts where the getThemeDefinition test was passing a ThemeDefinition object instead of a ThemeId to the function under test. This caused a TS2345 type error in the CI type-check step.
Changes Made:
Impact it Made: Resolves the CI failure on PR #2704. All other checks (Lint, CodeQL, Build, etc.) passed; only the type-check step failed.