prime sandbox ssh #244
Open
prime sandbox ssh #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| print(f" TLS Socket: {tcp_exposure.tls_socket}") | ||
| if tcp_exposure.external_port: | ||
| print(f" External Port: {tcp_exposure.external_port}") | ||
| time.sleep(120) |
There was a problem hiding this comment.
Excessive 120-second delay in demo file
The demo has a hardcoded time.sleep(120) (2 minutes) after exposing the TCP port, which is 12x longer than the 10-second sleep used after HTTP port exposure. This appears to be leftover debug or testing code that makes the demo unnecessarily slow to run. A shorter delay (similar to the HTTP case) would be more appropriate for a demo file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces SSH connectivity and protocol-aware port exposure across SDK and CLI.
prime sandbox sshcommand to create, authorize, and clean up SSH sessions;exposenow supports--protocol(HTTP/TCP/UDP) and shows external endpoints;list-portscan list all exposures across sandboxes.ExposePortRequestacceptsprotocol;ExposedPortincludesexternal_portandexternal_endpoint; newSSHSessionmodel;SandboxClient/AsyncSandboxClientaddlist_all_exposed_ports,create_ssh_session, andclose_ssh_session;exposeaccepts protocol.sandbox_port_expose_demo.pydemonstrating HTTP and TCP exposure with verification.SSHSessionin package__init__.Written by Cursor Bugbot for commit 175fd61. This will update automatically on new commits. Configure here.