0007 - Add ADR about module modern installation and the container issues#8
Open
jolelievre wants to merge 3 commits intoPrestaShop:masterfrom
Open
0007 - Add ADR about module modern installation and the container issues#8jolelievre wants to merge 3 commits intoPrestaShop:masterfrom
jolelievre wants to merge 3 commits intoPrestaShop:masterfrom
Conversation
jolelievre
force-pushed
the
module-installation
branch
from
e7d2150 to
d0ca02e
Compare
Contributor
|
@PierreRambaud I applied your feedbacks on @jolelievre PR. Can you review again ? Let's merge this ! |
Contributor
|
It looks like this ADR is kindof stale. We need to simply choose one solution and start using it everywhere. I suggest @eternoendless chooses the solution to use and then we can complete merge this ADR. |
…-advanced-installation.md
eternoendless
changed the title
Contributor
|
@jolelievre if you are OK, maybe we should close this? we were not able to manage this topic until a vote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ADR about module modern installation and the container issues