DCA1000.organize: fixed formatting for xWR14xx and other sensors #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obabarin
reviewed
Aug 13, 2021
| ret = np.zeros(len(raw_frame) // 2, dtype=complex) | ||
| ret = None | ||
|
|
||
| sensor_type = self.generalizedSensorType(sensor_type) |
Author
There was a problem hiding this comment.
What about it do you think is incorrect? I set ret to None b/c for real or complex data the size of ret should be different, they are then respectively defined in a later section. The generalizedSensorType is just one way of categorizing the different ways to partition the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DCA1000.organizemethod inadc.pydoes not correctly format the ADC data according to TI standards for certain sensors. This commit adds capability for all sensors that fall underxWR14xx, xWR16xx, IWR6843types for both real and complex data formats. TI data format standards for these models can be found in this PDF.An additional parameter
sensor_typeis added toDCA1000.organizein order to distinguish between these sensor types and their data formats.This commit adds a method
generalizedSensorTypethat, given a sensor name, returns the generalized name it belongs to. For examplegeneralizedSensorType("IWR1438") --> "xWR14xx".