Conversation
…nsaction record retrieval This commit updates the RuntimeRBAC test suite to improve error handling for role creation and transaction record retrieval. It introduces a method to detect 'ResourceAlreadyExists' reverts, allowing the tests to continue gracefully when roles already exist. Additionally, the logic for retrieving transaction records has been refined to prioritize expected transaction IDs from meta-transactions, enhancing the robustness of the testing framework.
…ollerDefinitions This commit updates the function signature for the executeWithTimeLock method in the GuardControllerDefinitions library to accurately reflect the parameter types. The change ensures consistency in the function selector and schema definition, enhancing clarity and preventing potential mismatches during contract execution.
This commit adds default Blox initializers to the env.deployment.example file, including addresses for the owner, recovery, and broadcaster, along with a timelock delay setting. Additionally, it updates the Hardhat configuration to include the hardhat-ethers plugin, ensuring compatibility for library linking during deployments. The deployment script is also refined to clarify the use of viem for contract deployment, improving error handling and output clarity for deployed addresses.
…nitions This commit introduces a new function selector for the executeWithPayment method in the GuardControllerDefinitions library. The addition enhances the library's functionality by allowing for payment execution with specified parameters, ensuring consistency and clarity in contract interactions.
This commit enhances the GuardController and RuntimeRBAC implementations by replacing local execution parameter generation with calls to their respective deployed definition contracts. This change ensures a single source of truth for action specifications and improves the accuracy of execution parameters. Additionally, it removes outdated local helper functions and updates related documentation to reflect the new approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.