Conversation
* Initial plan * Fix tool detail page icon to be theme-aware (dark/light mode) Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/1d192ffc-640c-4a9e-9d8f-96251f98fd16 Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> * Address review feedback: consolidate CSS and add theme-change handler for detail tab fallback icon Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/d7760afb-4ed5-4874-97a5-1bc4275d4dbc Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
…filters are active (#509) * Initial plan * feat: add visual indicator dot on filter button when filters are active Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/66184e84-c43b-4345-8093-4b9e767369f7 Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> * feat: add one-click clear button for active dropdown filters on filter icon Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/2f611815-65e8-44d8-b84c-47eb20959bb2 Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> * style: reuse search-filter-btn styles for filter-clear-btn, remove duplicate CSS Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/23c5d071-ba7f-43a5-9964-6170812cf4c0 Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> * Update src/renderer/index.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/renderer/index.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/renderer/index.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… notification banner (#511) * Initial plan * Pre-filter marketplace to new tools only when clicking homepage banner Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/fd0d5ced-b91b-4e39-8812-cc2c8c36b293 Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> Co-authored-by: Power-Maverick <danish.naglekar@hotmail.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [handlebars](https://github.com/handlebars-lang/handlebars.js). Updates `handlebars` from 4.7.8 to 4.7.9 - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.9/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.8...v4.7.9) --- updated-dependencies: - dependency-name: handlebars dependency-version: 4.7.9 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#513) Bumps the npm_and_yarn group with 1 update in the / directory: [lodash](https://github.com/lodash/lodash). Updates `lodash` from 4.17.21 to 4.18.1 - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.18.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [@xmldom/xmldom](https://github.com/xmldom/xmldom). Updates `@xmldom/xmldom` from 0.8.11 to 0.8.12 - [Release notes](https://github.com/xmldom/xmldom/releases) - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md) - [Commits](xmldom/xmldom@0.8.11...0.8.12) --- updated-dependencies: - dependency-name: "@xmldom/xmldom" dependency-version: 0.8.12 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bundle Size Report 📦
Bundle Analysis ReportsThe detailed bundle analysis reports are available in the workflow artifacts:
Download the artifacts from the workflow run to view interactive visualizations. Bundle size tracking is now active! This helps prevent bundle bloat. |
There was a problem hiding this comment.
Pull request overview
This PR updates the renderer UI to improve filtering UX (active-filter indicator + one-click clear), improves theme responsiveness for tool-detail icons, and adjusts marketplace navigation to support “new tools only” filtering. It also updates the pnpm lockfile with several transitive dependency changes.
Changes:
- Add filter button grouping + “clear active filters” buttons and an active-filter indicator dot across Installed Tools, Connections, and Marketplace.
- Update theme handling to refresh tool-detail fallback icons on theme changes, and streamline marketplace icon fallback rendering via
generateToolIconHtml. - Add marketplace “new tools only” filter support when navigating from the homepage notification.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/styles.scss | Adds styling for filter button grouping and the active-filters indicator dot; adjusts tool-detail icon span display. |
| src/renderer/modules/toolsSidebarManagement.ts | Toggles active-filter indicator and clear button visibility; hardens empty-state hint rendering. |
| src/renderer/modules/themeManagement.ts | Invokes and implements tool-detail icon refresh logic on theme changes. |
| src/renderer/modules/marketplaceManagement.ts | Adds filter indicator/clear behavior, extends active-filters logic to include “new only”, and consolidates icon fallback rendering via shared utility. |
| src/renderer/modules/initialization.ts | Wires up click handlers for the new clear-filter buttons; updates outside-click behavior for dropdown closing. |
| src/renderer/modules/homepageManagement.ts | Navigates to marketplace and applies the “new tools only” filter from the notification banner. |
| src/renderer/modules/connectionManagement.ts | Toggles active-filter indicator and clear button visibility; adds a dropdown-only filter clear helper. |
| src/renderer/index.html | Adds clear-filter buttons and groups filter controls for the three sidebars with improved aria labeling. |
| pnpm-lock.yaml | Updates multiple transitive dependencies and metadata, including a newly-recorded deprecation warning for @xmldom/xmldom. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| <img width="16" height="16" alt="Filter Icon" /> | ||
| </button> | ||
| <div class="filter-btn-group"> | ||
| <button class="search-filter-btn" id="connections-filter-btn" title="Filters and Sort" aria-label="Open filters and sort"> |
There was a problem hiding this comment.
The connections-filter-btn button is missing type="button". While it currently isn’t inside a <form>, the default button type is submit, which can cause accidental form submissions if the markup is refactored later. Add an explicit type="button" for consistency with the other filter buttons.
| <button class="search-filter-btn" id="connections-filter-btn" title="Filters and Sort" aria-label="Open filters and sort"> | |
| <button type="button" class="search-filter-btn" id="connections-filter-btn" title="Filters and Sort" aria-label="Open filters and sort"> |
| <img width="16" height="16" alt="Filter Icon" /> | ||
| </button> | ||
| <div class="filter-btn-group"> | ||
| <button class="search-filter-btn" id="marketplace-filter-btn" aria-label="Open marketplace filters and sort options" title="Filters and Sort"> |
There was a problem hiding this comment.
The marketplace-filter-btn button is missing type="button". Buttons default to submit, which can introduce unintended behavior if this UI ever ends up inside a <form>. Consider adding type="button" to match the other buttons in this toolbar.
| <button class="search-filter-btn" id="marketplace-filter-btn" aria-label="Open marketplace filters and sort options" title="Filters and Sort"> | |
| <button type="button" class="search-filter-btn" id="marketplace-filter-btn" aria-label="Open marketplace filters and sort options" title="Filters and Sort"> |
| '@xmldom/xmldom@0.8.12': | ||
| resolution: {integrity: sha512-9k/gHF6n/pAi/9tqr3m3aqkuiNosYTurLLUtc7xQ9sxB/wm7WPygCv8GYa6mS0fLJEHhqMC1ATYhz++U/lRHqg==} | ||
| engines: {node: '>=10.0.0'} | ||
| deprecated: this version has critical issues, please update to the latest version |
There was a problem hiding this comment.
@xmldom/xmldom@0.8.12 is recorded in the lockfile as deprecated with “critical issues, please update to the latest version”. Since this PR updates to that version, it would be good to follow through by upgrading to a non-deprecated release (via updating the parent dependency, or using a pnpm override) to avoid pulling in a known-bad transitive dependency.
| '@xmldom/xmldom@0.8.12': | |
| resolution: {integrity: sha512-9k/gHF6n/pAi/9tqr3m3aqkuiNosYTurLLUtc7xQ9sxB/wm7WPygCv8GYa6mS0fLJEHhqMC1ATYhz++U/lRHqg==} | |
| engines: {node: '>=10.0.0'} | |
| deprecated: this version has critical issues, please update to the latest version | |
| '@xmldom/xmldom@0.8.15': | |
| resolution: {integrity: sha512-9k/gHF6n/pAi/9tqr3m3aqkuiNosYTurLLUtc7xQ9sxB/wm7WPygCv8GYa6mS0fLJEHhqMC1ATYhz++U/lRHqg==} | |
| engines: {node: '>=10.0.0'} |
Please fill in this template.