Merge links on nodes: create super nodes#1398
Open
mgovers wants to merge 8 commits into
Open
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
commented
May 13, 2026
Comment on lines
+433
to
+448
| struct ReducedComponentTopology { | ||
| Idx n_node{}; // num of topological nodes (with reduced links), plus internal nodes for 3-way branches | ||
| std::vector<BranchIdx> branch_node_idx; | ||
| std::vector<Branch3Idx> branch3_node_idx; | ||
| IdxVector shunt_node_idx; | ||
| IdxVector source_node_idx; | ||
| IdxVector load_gen_node_idx; | ||
| std::span<LoadGenType const> load_gen_type; | ||
| IdxVector voltage_sensor_node_idx; | ||
| std::span<Idx const> power_sensor_object_idx; // the index is relative to branch, source, shunt or load_gen | ||
| std::span<MeasuredTerminalType const> power_sensor_terminal_type; | ||
| std::span<Idx const> current_sensor_object_idx; // the index is relative to branch | ||
| std::span<MeasuredTerminalType const> current_sensor_terminal_type; | ||
| std::span<ComponentType const> regulator_type; | ||
| std::span<Idx const> regulated_object_idx; // the index is relative to branch or branch3 | ||
| std::span<ComponentType const> regulated_object_type; |
Member
Author
There was a problem hiding this comment.
the span ones essentially do not change when we go from user nodes to topological nodes, so we can do with a pure view. The branch2, branch3 and appliance ones may change so they need a pass-by-copy.
We can also opt for a maybe_owning_view, which can either take by reference, or by value, depending on the situation. I'm investigating that on the side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #35
This actually creates the topological nodes from the regular nodes