Clean up main model: migrate out "calculation preparation" related stuff #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
figueroa1395
added
improvement
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
figueroa1395
commented
Oct 24, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
figueroa1395
commented
Oct 24, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Oct 24, 2025
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
This is a global review, not an in-depth one. Awesome cleanup!
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Oct 24, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
|
mgovers
reviewed
Nov 17, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Nov 17, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Nov 17, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Nov 17, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
mgovers
reviewed
Dec 12, 2025
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
great cleanup. couple minor remarks remaining
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/prepare_calculate.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_preparation.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
mgovers
reviewed
Dec 17, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_preparation.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Dec 17, 2025
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
great cleanup! one minor nitpick + clang-tidy fails
figueroa1395
changed the title
Member
Author
|
@mgovers Addressed all. I believe this is ready to be merged. Adding more unit tests becomes hard because of all the topology, components and such dependencies. I can try, but I don't think it adds much values at this point. If you agree, feel free to approve and send to merge queue. |
mgovers
approved these changes
Dec 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to remove all the stuff related to preparing the calculation/solvers out of the main model. This PR should be an enabler to unit test the touched logic more easily, keep trimming the main model, and get it ready to remove everything related to the calculation logic in a followup.