fix(git-redate): fix settings path#29
Open
euberdeveloper wants to merge 1 commit into
Open
Conversation
I noticed that in my pc (Ubuntu 20 - bash), using `SETTINGS_FILE="~/.redate-settings";` does not work when tested with `[ -f $SETTINGS_FILE ]`, while `SETTINGS_FILE="$HOME/.redate-settings"` does
|
I had the same issue a couple days ago. I just tested your patch and it works. The tilde is extended by bash but not when it is wrapped in quotes (according to this). So, another workaround would be to remove the quotes: |
SiteRelEnby
added a commit
to SiteRelEnby/git-redate
that referenced
this pull request
May 8, 2026
- SETTINGS_FILE used a quoted ~ which never expanded, so the script would write a file literally named '~/.redate-settings' in CWD every time the editor prompt fell through. Use $HOME. - mktemp was creating gitblah-XXXX in the working directory; switch to mktemp -t so it lands in $TMPDIR and can't be picked up by glob-happy git operations. - echo "...\n" was printing literal backslash-n; convert to printf. - Quote test variables and use single = so the editor-choice comparisons don't blow up on empty input. - read -r so backslashes in editor paths survive. - Add missing --no-show-signature on the n=5 fallback git log. The $HOME fix was independently proposed in upstream PR PotatoLabs#29 and the echo->printf fix in PR PotatoLabs#30; crediting those authors below. Co-authored-by: euberdeveloper <33126163+euberdeveloper@users.noreply.github.com> Co-authored-by: lc-at <30001379+lc-at@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in my pc (Ubuntu 20 - bash), using
SETTINGS_FILE="~/.redate-settings";does not work when tested with[ -f $SETTINGS_FILE ], whileSETTINGS_FILE="$HOME/.redate-settings"does