feat(react-native): support survey schedule 'always' (show every time)#2966
Merged
feat(react-native): support survey schedule 'always' (show every time)#2966
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Graphite Automations"sdk release label" took an action on this PR • (01/24/26)1 label was added to this PR based on Adam Bowker's automation. |
Contributor
Contributor
|
Size Change: +658 B (+0.01%) Total Size: 5.88 MB
ℹ️ View Unchanged
|
marandaneto
approved these changes
Jan 24, 2026
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Add support for the `schedule: 'always'` survey configuration option in React Native SDK to match the browser SDK behavior. Changes: - Add SurveySchedule enum to core package types - Add schedule property to Survey type in core package - Update React Native canActivateRepeatedly function to check for schedule === SurveySchedule.Always - Add tests for the new behavior Closes #2961 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
adboio
force-pushed
the
feat/rn-survey-schedule-always
branch
from
bb8457d to
1f061cb
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
adboio
added a commit
to PostHog/posthog
that referenced
this pull request
Feb 3, 2026
## Problem updating survey version reqs with new features: - PostHog/posthog-js#2967 - PostHog/posthog-js#2966 <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> ## Changes <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with [PostHog coding conventions](https://posthog.com/docs/contribute/coding-conventions) for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
warpbuild-benchmark-bot Bot
added a commit
to WarpBuilds/benchmarks-posthog
that referenced
this pull request
Feb 3, 2026
## Problem updating survey version reqs with new features: - PostHog/posthog-js#2967 - PostHog/posthog-js#2966 <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> ## Changes <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with [PostHog coding conventions](https://posthog.com/docs/contribute/coding-conventions) for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
fercgomes
pushed a commit
to PostHog/posthog
that referenced
this pull request
Feb 4, 2026
## Problem updating survey version reqs with new features: - PostHog/posthog-js#2967 - PostHog/posthog-js#2966 <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> ## Changes <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with [PostHog coding conventions](https://posthog.com/docs/contribute/coding-conventions) for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SurveyScheduleenum to core package types with valuesOnce,Recurring, andAlwaysscheduleproperty toSurveytype in core packagecanActivateRepeatedlyfunction to check forschedule === SurveySchedule.Always, matching browser SDK behaviorTest plan
schedule: 'always'surveys being shown even when already seenschedule: 'once'surveys being excluded when already seenCloses #2961
🤖 Generated with
Claude CodeTWIG! 🦔