chore: Sensitive data refactor part 1#2886
Closed
luke-belton wants to merge 2 commits intomainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
luke-belton
commented
Jan 13, 2026
| * @returns {boolean} whether the element should be captured | ||
| * @returns {boolean} whether the element is marked as no-capture | ||
| */ | ||
| export function shouldCaptureElement(el: Element): boolean { |
Contributor
Author
There was a problem hiding this comment.
moved to doesCaptureElementHaveSensitiveData in sensitive-data-detection.ts
luke-belton
commented
Jan 13, 2026
| * @param {Element} el - element to check | ||
| * @returns {boolean} whether the element should be captured | ||
| */ | ||
| export function isSensitiveElement(el: Element): boolean { |
Contributor
Author
There was a problem hiding this comment.
moved to isSensitiveElement in sensitive-data-detection.ts
Contributor
|
Size Change: +1.15 kB (+0.02%) Total Size: 5.75 MB
ℹ️ View Unchanged
|
This was referenced Jan 13, 2026
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Contributor
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building off #2647 and the feedback at https://posthog.slack.com/archives/C075D3C5HST/p1764603130371689.
Changes
This is part 1 of a refactor of how we handle sensitive data.
It's basically a refactor with (hopefully!) no behavior changes. In summary it:
To be followed by two more PRs for part 2 and 3 of the refactor!
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file