feat: super properties for posthog-node#2729
feat: super properties for posthog-node#2729harshit078 wants to merge 2 commits intoPostHog:mainfrom
Conversation
|
@harshit078 is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @pauldambra , can you review the PR ? Thanks ! |
|
hey Harshit! I'll review this one tomorrow - got stuck today fixing some other issues, but it's on my list |
lucasheriques
left a comment
There was a problem hiding this comment.
Thanks for the PR! The implementation looks good and the tests are solid.
One thing to clarify: since the Node SDK uses in-memory storage, register() properties only persist for the lifetime of the PostHog client instance. This is useful for long-running processes (Express servers, workers) but won't help in serverless environments where each invocation creates a new client.
Before merging, could you:
- Run
pnpm changesetto generate a changeset (I see it's unchecked in the PR checklist) - Add JSDoc to the
register()method in the Node SDK explaining the behavior: - Optionally, a docs update in the posthog.com repo (
contents/docs/libraries/node/index.mdx) would be great but can be a follow-up
|
Hey @lucasheriques , sure I'll do the 3 steps and update the PR. Thanks ! |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
Hey @lucasheriques, I've updated the changeset as required. If needed this PR can be reviewed again. Thanks ! |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
Changes
registeredPropertiesinprepareEventMessageprepareEventMessageto ensure that every event includes globally registered super properties.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file