chore: Expose userProperties, userPropertiesSetOnce capture method #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jan 20, 2026
lib/posthog_flutter_web.dart
Outdated
| userPropertiesSetOnce: userPropertiesSetOnce, | ||
| ); | ||
|
|
||
| final normalizedProperties = extracted.properties != null |
Member
Author
There was a problem hiding this comment.
PropertyNormalizer is more strict than just web safeMapConversion so lets do this here as well
marandaneto
commented
Jan 20, 2026
| /// | ||
| /// New parameters (userProperties, userPropertiesSetOnce) take precedence | ||
| /// over legacy $set and $set_once in properties. | ||
| static ExtractedCaptureProperties extractUserProperties({ |
Member
Author
There was a problem hiding this comment.
keep back compatibility since i told people to use $set and $set_once before thru the properties object
ioannisj
approved these changes
Jan 22, 2026
Collaborator
ioannisj
left a comment
ioannisj
left a comment
There was a problem hiding this comment.
Just a couple of comments but looks good.
Good thinking with backward compatibility even though I think it adds complexity and I'm not sure it's really worth it. Maybe just a deprecation warning would do? Up to you
Co-authored-by: Ioannis J <yiannis@posthog.com>
…flutter into chore/userprops-capture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #119
💚 How did you test it?
running sdks
📝 Checklist