chore: exception web #243
chore: exception web #243
Conversation
|
still a few things to figure out eg https://posthog.slack.com/archives/C07AA937K9A/p1768489092736519?thread_ts=1768415443.965209&cid=C07AA937K9A |
| true; // Capture isolate errors | ||
|
|
||
| await Posthog().setup(config); | ||
| if (kIsWeb) { |
There was a problem hiding this comment.
web needs runZonedGuarded and mobile/desktop do not
we have to add docs for this
| } | ||
| } | ||
|
|
||
| // Stack line parser type |
There was a problem hiding this comment.
I ported the code from the JS SDK since i could make it work reusing that part of the JS SDK because the error tracking bits is a plugin downloaded async and its never available when i want to
we can probably ditch this later if i manage to make it working
There was a problem hiding this comment.
Oh, then we better leave this unchanged I guess, so feel free to ignore the comments below
marandaneto
requested review from
ablaszkiewicz and
oliverb123
and removed request for
oliverb123
ablaszkiewicz
left a comment
ablaszkiewicz
left a comment
There was a problem hiding this comment.
Difficult to review dart code for me but from the tests I did it looks like it's working. We are getting exceptions with correct titles, descriptions and stack traces
| } | ||
| } | ||
|
|
||
| // Stack line parser type |
There was a problem hiding this comment.
Oh, then we better leave this unchanged I guess, so feel free to ignore the comments below
💡 Motivation and Context
Closes #237
source code context not possible yet due to flutter/flutter#87734
also flutter/flutter#145111 but less of a blocker since it only is needed for not in app code
💚 How did you test it?
running example on prod
debug builds dont have chunk ids
📝 Checklist