Skip to content

fix: qualify source-less dotnet stack frames#220

Draft
cat-ph wants to merge 1 commit into
mainfrom
fix/dotnet-source-less-frames
Draft

fix: qualify source-less dotnet stack frames#220
cat-ph wants to merge 1 commit into
mainfrom
fix/dotnet-source-less-frames

Conversation

@cat-ph
Copy link
Copy Markdown

@cat-ph cat-ph commented Jun 4, 2026

Summary

  • Qualifies source-less .NET stack frame functions with their declaring type.
  • Keeps filename and abs_path empty when .NET has no PDB/source file path.
  • Adds regression coverage for dynamically compiled source-less frames.

Tests

  • nix shell nixpkgs#dotnet-sdk_9 --command dotnet test tests/UnitTests/UnitTests.csproj -f net8.0 --filter "CaptureExceptionWithoutSourceInfoQualifiesFunctionName|CaptureExceptionWithInvalidFilePathInStackFrame"
  • DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 nix shell nixpkgs#dotnet-sdk_9 --command dotnet test tests/UnitTests/UnitTests.csproj -f net8.0 --no-restore
  • nix shell nixpkgs#dotnet-sdk_9 --command dotnet format PostHog.sln --verify-no-changes --no-restore
  • Local repro in /Users/cat/p/experiments/dotnet-stacktrace-source-repro
  • ~/.codex/skills/autoreview/scripts/autoreview --mode branch --base origin/main

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

posthog-dotnet Compliance Report

Date: 2026-06-04 00:30:33 UTC
Duration: 605ms

⚠️ Some Tests Failed

2/16 tests passed, 14 failed


Feature_Flags Tests

⚠️ 2/16 tests passed, 14 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 41ms
Request Payload.Flags Request Uses V2 Query Param 21ms
Request Payload.Flags Request Hits Flags Path Not Decide 5ms
Request Payload.Flags Request Omits Authorization Header 4ms
Request Payload.Token In Flags Body Matches Init 5ms
Request Payload.Groups Round Trip 5ms
Request Payload.Groups Default To Empty Object 5ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 5ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 4ms
Request Payload.Disable Geoip Omitted Defaults To False 5ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 5ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 180ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 6ms
Request Lifecycle.Mock Response Value Is Returned To Caller 5ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 5ms

Failures

request_payload.request_with_person_properties_device_id

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_uses_v2_query_param

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_hits_flags_path_not_decide

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_omits_authorization_header

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.token_in_flags_body_matches_init

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_round_trip

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_default_to_empty_object

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.person_properties_distinct_id_auto_populated_when_caller_omits_it

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_false_propagates_as_geoip_disable_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_omitted_defaults_to_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flag_keys_to_evaluate_contains_only_requested_key

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.two_flag_calls_produce_two_remote_requests

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.mock_response_value_is_returned_to_caller

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

side_effect_events.get_feature_flag_captures_feature_flag_called_event

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant