Skip to content

Fix Trino catalog creation: use fs.native-s3.enabled (Trino 476) #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bill-ph merged 1 commit into from
Jun 4, 2026
+10 −7
Merged

Fix Trino catalog creation: use fs.native-s3.enabled (Trino 476) #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions controlplane/provisioner/trino_provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,11 +955,14 @@ func (p *TrinoProvisioner) reconcileCatalogs(ctx context.Context, orgs []configs
// credentials are embedded here — just the endpoint, the warehouse
// name, and the per-org S3 IAM role.
//
// Property names follow Trino's current file-system / Iceberg-REST
// surface (matching the working maintenance chart at
// charts/charts/trino/files/trino_maintenance.py):
// Property names MUST stay in sync with the working maintenance chart at
// charts/charts/trino/files/trino_maintenance.py — this set drifted from it
// once (fs.s3.enabled vs fs.native-s3.enabled), which Trino 476 rejects at
// CREATE CATALOG ("Configuration property 'fs.s3.enabled' was not used"):
//
// fs.s3.enabled=true enable the unified S3 file system
// fs.native-s3.enabled=true enable Trino's native S3 file system
// (required since Trino 458; the legacy
// Hadoop fs.s3.* surface is rejected by 476)
// s3.region=<region> forwarded to the AWS SDK
// s3.iam-role=<arn> per-org duckling-<orgid> role
//
Expand All @@ -974,7 +977,7 @@ func (p *TrinoProvisioner) buildCatalogProperties(orgID string, ic *configstore.
"iceberg.catalog.type": "rest",
"iceberg.rest-catalog.uri": ic.LakekeeperEndpoint,
"iceberg.rest-catalog.warehouse": ic.LakekeeperWarehouse,
"fs.s3.enabled": "true",
"fs.native-s3.enabled": "true",
}
if p.iamAccountID != "" {
props["s3.iam-role"] = fmt.Sprintf("arn:aws:iam::%s:role/duckling-%s", p.iamAccountID, orgID)
Expand Down
4 changes: 2 additions & 2 deletions controlplane/provisioner/trino_provisioner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ func TestReconcile_CreatesCatalogProjectsSecretAndConfigMap(t *testing.T) {
if !strings.Contains(props["s3.iam-role"], "duckling-42") {
t.Errorf("expected duckling-42 role ARN under s3.iam-role, got %q", props["s3.iam-role"])
}
if props["fs.s3.enabled"] != "true" {
t.Errorf("expected fs.s3.enabled=true, got %q", props["fs.s3.enabled"])
if props["fs.native-s3.enabled"] != "true" {
t.Errorf("expected fs.native-s3.enabled=true, got %q", props["fs.native-s3.enabled"])
}
// Old property names must NOT be emitted — they're silently ignored
// or rejected by current Trino.
Expand Down
Loading