feat(signals): add option for default team channel for signals notifications#2487
Merged
Conversation
Expose the team-level default Slack channel (SignalTeamConfig.slack_notification_channel) in the inbox configuration, editable by org admins, alongside the existing per-user notification channel. Both options are explained in the UI. Extracts a shared SlackChannelCombobox so the team-default and per-user pickers reuse one implementation. The team channel lists from the team's first slack integration, matching how the backend resolves the integration at send time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/settings/components/SlackChannelCombobox.tsx:213-215
**Trigger icon always shows `Hash` for private channels**
The trigger button hardcodes `Hash` regardless of whether the saved channel is private. The current target value format (`channelId|#channelName`) doesn't carry privacy info, so the trigger can't distinguish. Compound this with `configuredSlackChannelOption` always setting `is_private: false` — even the synthesised dropdown entry for a previously-saved private channel will show `Hash` instead of `Lock` until the API response arrives and replaces it. The practical effect is that users with a private channel configured see a misleading public icon in both the trigger and the initial dropdown render.
Reviews (1): Last reviewed commit: "default notifications ui for team" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
joshsny
force-pushed
the
signals-team-default-notification-channel
branch
from
12b710c to
d776d7a
Compare
tatoalo
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a default channel for inbox notifications for your team to post all signal reports to. Users can override with their own channel for high priority notifications.