pulseaudio: Rework enough bytes written bytes or not enough bytes to read#1120
Conversation
illuusio
force-pushed
the
pulseaudio-issue-1119
branch
from
0002c81 to
0fcd938
Compare
illuusio
force-pushed
the
pulseaudio-issue-1119
branch
from
0fcd938 to
da1bfd5
Compare
|
Tested and that fixes the issue #1119 for me. |
illuusio
force-pushed
the
pulseaudio-issue-1119
branch
from
ae614b4 to
c5a1e2e
Compare
|
Thank you for looking into this. I've rebased your changes to one commit. |
|
You can squash the typo fixup commit into your initial commit and there is no need for mentioning me as co-author for such trivial change. |
…read Rework we have written enough bytes to output or we don't have enough bytes to read in pulseaudio
illuusio
force-pushed
the
pulseaudio-issue-1119
branch
from
c5a1e2e to
6b682c6
Compare
|
If it's ok to you I've just updated PR |
|
@illuusio wrote:
Adding to a PR is fine but please do not force-push to non-draft PRs. |
RossBencina
left a comment
RossBencina
left a comment
There was a problem hiding this comment.
We are going to merge this as an emergency fix that reverts to previous known-better behavior of 7966aac. However, under normal circumstances:
-
The comment is unacceptably bad. It is unclear whether it adds anything. We seriously considered deleting it but for the sake of keeping history we have retained it.
-
The logic does not look correct. We have opened issue #1128 in which we will shortly add more detail.
4 participants
Rework we have written enough bytes to output or we don't have enough bytes to read in pulseaudio. This should fix issue #1119