Skip to content

remove proto completely as we are no longer planning to support it#2617

Open
ljeub-pometry wants to merge 5 commits into
db_v4from
remove_proto
Open

remove proto completely as we are no longer planning to support it#2617
ljeub-pometry wants to merge 5 commits into
db_v4from
remove_proto

Conversation

@ljeub-pometry
Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

removes all code related to the old proto graph format

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c977b9f Previous: 9823ef7 Ratio
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 4 ns/iter (± 0) 1 ns/iter (± 0) 4
lotr_graph/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph/iterate_exploded_edges 636181 ns/iter (± 9275) 285473 ns/iter (± 2920) 2.23
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 8162689 ns/iter (± 36019) 1564816 ns/iter (± 35303) 5.22
lotr_graph_window_100/num_nodes 14 ns/iter (± 0) 5 ns/iter (± 0) 2.80
lotr_graph_window_100/iterate_exploded_edges 876636 ns/iter (± 1226) 325242 ns/iter (± 847) 2.70
lotr_graph_window_100_materialise/materialize 8513843 ns/iter (± 40211) 1669150 ns/iter (± 10700) 5.10
lotr_graph_window_10/has_node_existing 154 ns/iter (± 9) 62 ns/iter (± 11) 2.48
lotr_graph_window_10/iterate nodes 35944 ns/iter (± 82) 11339 ns/iter (± 40) 3.17
lotr_graph_window_10/iterate edges 102206 ns/iter (± 767) 48684 ns/iter (± 211) 2.10
lotr_graph_window_10/iterate_exploded_edges 419415 ns/iter (± 587) 155788 ns/iter (± 1001) 2.69
lotr_graph_window_10_materialise/materialize 3634851 ns/iter (± 6565) 971980 ns/iter (± 4278) 3.74
lotr_graph_subgraph_10pc/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_subgraph_10pc_materialise/materialize 1672516 ns/iter (± 33071) 334634 ns/iter (± 1287) 5.00
lotr_graph_subgraph_10pc_windowed/has_node_existing 160 ns/iter (± 10) 62 ns/iter (± 14) 2.58
lotr_graph_subgraph_10pc_windowed/iterate nodes 5549 ns/iter (± 91) 1365 ns/iter (± 3) 4.07
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1026530 ns/iter (± 16066) 230399 ns/iter (± 2617) 4.46
lotr_graph_window_50_layered/num_edges 77809 ns/iter (± 1244) 38714 ns/iter (± 1017) 2.01
lotr_graph_window_50_layered/num_edges_temporal 164636 ns/iter (± 3067) 70121 ns/iter (± 7586) 2.35
lotr_graph_window_50_layered/has_node_existing 465 ns/iter (± 26) 129 ns/iter (± 12) 3.60
lotr_graph_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_window_50_layered/iterate nodes 82043 ns/iter (± 726) 19308 ns/iter (± 47) 4.25
lotr_graph_window_50_layered/iterate edges 206886 ns/iter (± 321) 83616 ns/iter (± 1318) 2.47
lotr_graph_window_50_layered/graph_latest 81726 ns/iter (± 1814) 36649 ns/iter (± 916) 2.23
lotr_graph_window_50_layered_materialise/materialize 33981717 ns/iter (± 163483) 3488825 ns/iter (± 24948) 9.74
lotr_graph_persistent_window_50_layered/num_edges_temporal 685917 ns/iter (± 5734) 192686 ns/iter (± 1569) 3.56
lotr_graph_persistent_window_50_layered/has_node_existing 506 ns/iter (± 357) 174 ns/iter (± 83) 2.91
lotr_graph_persistent_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_persistent_window_50_layered/iterate nodes 107522 ns/iter (± 947) 35886 ns/iter (± 191) 3.00
lotr_graph_persistent_window_50_layered/iterate edges 192686 ns/iter (± 5009) 84161 ns/iter (± 596) 2.29
lotr_graph_persistent_window_50_layered/iterate_exploded_edges 4865808 ns/iter (± 13642) 1659940 ns/iter (± 19402) 2.93
lotr_graph_persistent_window_50_layered/graph_latest 119671 ns/iter (± 1978) 57549 ns/iter (± 4809) 2.08
lotr_graph_persistent_window_50_layered_materialise/materialize 60832182 ns/iter (± 114325) 5298035 ns/iter (± 147912) 11.48

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Collaborator

@fabianmurariu fabianmurariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't see prost being removed from Raphtory/Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants