Skip to content

Making the get_graph method public #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigolece wants to merge 1 commit into
base: db_v4
Choose a base branch
from
Open

Making the get_graph method public #2609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion raphtory-graphql/src/data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl Data {
/// # ⚠ Bypasses all permission checks — do not call from resolvers directly.
/// Use `get_graph_with_read_permission`, `get_raw_graph_with_read_permission`, or
/// `get_graph_with_write_permission` instead.
async fn get_graph(&self, path: &str) -> Result<GraphWithVectors, Arc<GQLError>> {
Copy link
Copy Markdown
Collaborator

@ljeub-pometry ljeub-pometry May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should not be public as it bypasses all permissions checks, you should be using get_graph_with_read_permissions or get_graph_with_write_permission (depending on whether the graph will be modified) instead as per the comment above.

pub async fn get_graph(&self, path: &str) -> Result<GraphWithVectors, Arc<GQLError>> {
self.cache
.try_get_with(path.into(), self.read_graph_from_disk(path))
.await
Expand Down
Loading