Conversation
So we actually enforce a style!
This was deceivingly simple... is this really all there is to it?!
(Basically transplanting the test file used during dev!)
Collaborator
Author
|
@Pomax This was basically copied of off existing code, to get to the Bangers chars as detailed in #153 I would love a pair of extra eyes on this, as even though I seem to be getting the data I want, I might be oversimplifying. I'll be testing this tomorrow with more fonts, and seeing if and how this works together with Wakamai Fondue. |
Collaborator
Author
|
I tested some more fonts from the Google Fonts repo, these all seem to be working nicely! Pretty thrilled this seems to be all there is to it. But waiting for you to confirm, @Pomax! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to kickstart type 6, format 2 parsing by looking at what's missing and peeking from existing code on how to solve this :P
Currently simply attempting to get the info we see in the TTX dump here: #153 (comment)
Code to test Bangers with this PR (so far), our test font with confirmed 6.2 lookup. EDIT: or use the
gsub.test.jstest!