This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Fix animation end callback in manual mode#143
Open
jtagscherer wants to merge 3 commits intoPolymerElements:masterfrom
Open
Fix animation end callback in manual mode#143jtagscherer wants to merge 3 commits intoPolymerElements:masterfrom
jtagscherer wants to merge 3 commits intoPolymerElements:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132.
Previously, switching to manual mode would, among other listeners, deregister the
animationendlistener. Therefore, after an animation that had been manually started by the user had finished, the necessary callback would not be executed. The_animationPlayingflag would not be set tofalseafter playback, causing subsequent animations to be cancelled. This pull request fixes this issue by keeping this necessary callback active for the whole lifecycle of thepaper-tooltip.