Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Conversation

@guss77
Copy link

@guss77 guss77 commented Dec 25, 2017

Add support for readonly attribute on paper-toggle-button.

I'm not sure about my use of overriding IronButtonState's event handler, but that's the only way I could find to capture the tap early enough to be canceled elegantly, but more specifically I'm not sure about the syntax for calling the original event handler - though it seems to work well, at least on Polymer 2.

It looks like the child's tap handler is called very late in the process, instead override IronButtonState's tap handler and cancel it if readonly is set
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@guss77
Copy link
Author

guss77 commented Dec 25, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@guss77 guss77 mentioned this pull request Dec 25, 2017
@cdreisbach
Copy link

Any progress on this PR? Would be nice to implement it in the master as soon as possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants