You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds code paths and tests to support selecting all of the items in the list or batch selecting a subset of the list. Further the ideas introduces in #437, this relies on extensions to both Polymer 1.x and 2.x to empower array-selector with selectItems and selectAll functionality and forks the application of that code as needed in this hybrid component.
Based on the response from the Polymer team in Polymer/polymer#4699 (comment) would a PR that included a custom iron-list-selector element be something that would be acceptable? Trying to see whether I should push back on that comment or whether that seems reasonable that this level of responsibility be passed down to the iron-list component.
I guess one alternate possibility would be to have a stand alone component/repo that handled these responsibilities and then require it in iron-list but I’m not sure the right place to expect that to be managed. Thoughts?
Would that still block this PR on 1.x not having this capability? Can we move to a non-hybrid iron-list, yet? Just trying to figure out the right way to move this forward. Thanks for any suggestions.
I would lean towards just baking iron-list-selector functionality right into iron-list if that's possible. Having different code paths to maintain hybrid compatibility would be acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436
Relates to #361 (would make any batch selecting therein also not be slow)
Relies on:
Polymer/polymer#4699
Polymer/polymer#4705
Adds code paths and tests to support selecting all of the items in the list or batch selecting a subset of the list. Further the ideas introduces in #437, this relies on extensions to both Polymer 1.x and 2.x to empower
array-selectorwith selectItems and selectAll functionality and forks the application of that code as needed in this hybrid component.