Fixes to app-grid demo for Firefox and Edge#530
Open
gdevacc12 wants to merge 2 commits intoPolymerElements:masterfrom
gdevacc12:master
Open
Fixes to app-grid demo for Firefox and Edge#530gdevacc12 wants to merge 2 commits intoPolymerElements:masterfrom gdevacc12:master
gdevacc12 wants to merge 2 commits intoPolymerElements:masterfrom
gdevacc12:master
Conversation
Update md-grid-layout.html
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #528
https://github.com/PolymerElements/app-layout/issues/528
Images fail to appear in Firefox as
--app-grid-item-heightis not set. Added to:hostsection as it only appears in the media query section.Also added
screen andto the media query as Edge seemed to ignore the query otherwise.Re-tested the demo with Chrome 62, Opera 49 & 48, Firefox 57 & 56 Edge 40.15063.674.0.