feat(client): support for multiple position merges#123
Open
cesarenaldi wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_transaction(...)methods for custom transaction call batches.merge_multiple_positions(...)helpers for batch combo-position merges with per-positionamountsupport.Linear: DEV-344
Verification
uv run ruff format --check .uv run ruff check .uv run pyrightuv run pytestNote
Medium Risk
Changes submit on-chain merge transactions via the authenticated wallet; logic reuses existing dispatch and balance resolution but incorrect amounts or IDs could affect user positions.
Overview
Adds public wallet APIs on sync and async secure clients:
execute_transactionsubmits an ordered list ofTransactionCallvalues through the existing gasless/EOA dispatch path (empty call lists rejected), andmerge_multiple_positionsbatches combo merges in one relayed transaction with optional per-positionamountor"max".Introduces the exported
MergePositionRequesttyped dict and refactors combo outcome token IDs intoderive_combo_outcome_position_idsfor reuse when resolving balances before eachmerge_v2_call. README examples cover custom call batches and multi-combo merges; unit tests assert relayer submit payloads and validation errors.Reviewed by Cursor Bugbot for commit 31d2d1b. Bugbot is set up for automated code reviews on this repo. Configure here.