feat(rfq): expose RFQ error IDs#111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note
Low Risk
Small additive API on RFQ error types and stricter validation only when error_id is present; no auth or trading path changes.
Overview
RFQ websocket RFQ_ERROR responses can include an
error_idfor support and correlation. The quoter session now reads that field (optional string), rejects malformed non-string values withUnexpectedResponseError, and attacheserror_idonRfqQuoteRejectedError,RfqCancelQuoteRejectedError, andRfqConfirmationRejectedError.RfqErrorCodeaddsINVALID_SIGNATUREandINTERNAL_ERRORso those server codes parse without unknown-code failures. Integration coverage assertserror_idon quote rejection.Reviewed by Cursor Bugbot for commit c907fc6. Bugbot is set up for automated code reviews on this repo. Configure here.