Skip to content

feat(rfq): expose RFQ error IDs#111

Merged
cesarenaldi merged 1 commit into
mainfrom
feat/rfq-error-id
Jun 19, 2026
Merged

feat(rfq): expose RFQ error IDs#111
cesarenaldi merged 1 commit into
mainfrom
feat/rfq-error-id

Conversation

@AnanthVivekanand

@AnanthVivekanand AnanthVivekanand commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Parse RFQ error_id payloads.
  • Expose error_id on RFQ rejection errors.
  • Recognize INVALID_SIGNATURE and INTERNAL_ERROR.

Validation

  • make check
  • RFQ integration tests require credentials and were skipped locally.

Note

Low Risk
Small additive API on RFQ error types and stricter validation only when error_id is present; no auth or trading path changes.

Overview
RFQ websocket RFQ_ERROR responses can include an error_id for support and correlation. The quoter session now reads that field (optional string), rejects malformed non-string values with UnexpectedResponseError, and attaches error_id on RfqQuoteRejectedError, RfqCancelQuoteRejectedError, and RfqConfirmationRejectedError.

RfqErrorCode adds INVALID_SIGNATURE and INTERNAL_ERROR so those server codes parse without unknown-code failures. Integration coverage asserts error_id on quote rejection.

Reviewed by Cursor Bugbot for commit c907fc6. Bugbot is set up for automated code reviews on this repo. Configure here.

@AnanthVivekanand AnanthVivekanand marked this pull request as ready for review June 18, 2026 02:23
@cesarenaldi cesarenaldi merged commit a537547 into main Jun 19, 2026
7 checks passed
@cesarenaldi cesarenaldi deleted the feat/rfq-error-id branch June 19, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants