Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds type checking support to the package by including a py.typed marker file, enabling type checkers like mypy to validate types when users import this library.
Changes:
- Added
py.typedmarker file configuration to setup.py
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Well, adding py.typed is not enough. Actually PR should add type checker and fix all errors found. |
|
While it's not strictly enough, is does indicate that it's moving in the right direction. I'd strongly recommend merging this, and then continuing to fix the issues as a separate topic. This will remove Pyright's "missing type stubs" errors right away, which is a win on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added py.typed marker file to the package directory to indicate that a package supports static type checking.
Without py.typed: Type checkers treat your library as
Any, so users won't get type validation for your functions.UPD Well, adding py.typed is not enough. Actually PR should add type checker and fix all errors found.
Note
Low Risk
Packaging-only change that marks the library as typed; no runtime logic changes and minimal risk beyond distribution/config correctness.
Overview
Marks
py_clob_clientas a typed package by adding thepy.typedmarker and ensuring it is included in the published distribution viapackage_datainsetup.py, enabling static type checkers to use the library’s type hints.Written by Cursor Bugbot for commit 8633150. This will update automatically on new commits. Configure here.