Fix: regenerate HMAC headers for each pagination request#210
Closed
taetaehoho wants to merge 1 commit intoPolymarket:mainfrom
Closed
Fix: regenerate HMAC headers for each pagination request#210taetaehoho wants to merge 1 commit intoPolymarket:mainfrom
taetaehoho wants to merge 1 commit intoPolymarket:mainfrom
Conversation
The get_trades, get_orders, and get_builder_trades methods generate HMAC authentication headers once before the pagination loop, then reuse them for all subsequent requests. Since HMAC signatures include a timestamp and have a validity window on the server, this causes 401 Unauthorized errors when pagination takes longer than the signature validity period. This is particularly problematic for users with many trades/orders who require multiple pagination requests to fetch all data. The fix moves header generation inside the pagination loop so each request gets fresh headers with a current timestamp. Affected methods: - get_trades() - get_orders() - get_builder_trades()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix HMAC signature expiry during pagination in
get_trades(),get_orders(), andget_builder_trades()methods.Description
The paginated methods generate HMAC authentication headers once before the pagination loop, then reuse them for all subsequent requests. Since HMAC signatures include a timestamp and have a server-side validity window (~60 seconds), this causes 401 Unauthorized errors when:
Example: A user with 70,000+ trades needs ~230 pagination requests. Using the same headers for all requests eventually causes the signature to expire mid-pagination.
Fix: Move
create_level_2_headers()call inside thewhileloop so each pagination request gets fresh headers with a current timestamp.Testing
Is this a breaking change?
Type
Note
Regenerates Level 2/builder auth headers inside pagination loops for
get_orders,get_trades, andget_builder_tradesto prevent signature expiry.get_orders,get_trades: movecreate_level_2_headersinside thewhileloop to refresh HMAC per page.get_builder_trades: regenerate builder headers each iteration via_get_builder_headers.Written by Cursor Bugbot for commit 4b26a8f. This will update automatically on new commits. Configure here.