refactor: use SDK-native types for CLI parsing, centralize client initialization & output helpers#13
Open
suhailkakar wants to merge 6 commits intomainfrom
Open
refactor: use SDK-native types for CLI parsing, centralize client initialization & output helpers#13suhailkakar wants to merge 6 commits intomainfrom
suhailkakar wants to merge 6 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
suhailkakar
changed the title
| use tabled::settings::{Modify, Style, Width}; | ||
|
|
||
| /// Display string for missing/null values in table output. | ||
| pub const NONE: &str = "—"; |
There was a problem hiding this comment.
might be confusing calling this NONE, maybe something like EMPTY is better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Broad refactor across many commands changes CLI argument types and request construction, which can subtly break parsing or behavior even though functionality is largely unchanged.
Overview
Refactors CLI argument parsing to use SDK-native types (
Address,B256,U256) across commands, removing manualparse_address/parse_condition_idhelpers and centralizing common conversions via the newenum_from!macro andascending_flag()helper.Improves runtime wiring and config flexibility by lazy-initializing shared SDK clients in
main.rs, centralizing error rendering viaoutput::print_error, sharing the Polygon USDC address viaUSDC_ADDRESS_STR, and allowing RPC endpoint override viaPOLYMARKET_RPC_URL.Reorganizes output + wallet handling by splitting the huge
output/clob.rsinto focusedoutput/clob/*modules and deduplicating private-key hex normalization viawallet::signer_key_hex(used bywalletandsetup).Written by Cursor Bugbot for commit 313860a. This will update automatically on new commits. Configure here.