Fix base64url secret decoding in HMAC signing#219
Open
powfan wants to merge 1 commit intoPolymarket:mainfrom
Open
Fix base64url secret decoding in HMAC signing#219powfan wants to merge 1 commit intoPolymarket:mainfrom
powfan wants to merge 1 commit intoPolymarket:mainfrom
Conversation
cc48565 to
541f904
Compare
bh1337x
approved these changes
Dec 4, 2025
|
I was facing the same issue and it appears that this is the correct solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretas base64url (may contain_/-, padding omitted).atob, which only accepts standard base64, causingInvalidCharacterErrorwhen the secret includes url-safe chars.Testing
Note
Normalize base64url secrets (convert -/_ and add padding) before atob in base64ToArrayBuffer to prevent decode errors.
base64ToArrayBufferinsrc/signing/hmac.tsto normalize base64url (replace-/_, add padding) before decoding withatob, ensuring secrets decode consistently across runtimes.Written by Cursor Bugbot for commit 541f904. This will update automatically on new commits. Configure here.