Open
Conversation
Adds a script to fetch all orders via the API and write them to a JSON file, allowing users to archive their trading history.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| def main() -> None: | ||
| client = Polymarket() | ||
| orders = client.get_all_orders() # type: ignore |
There was a problem hiding this comment.
Script calls nonexistent get_all_orders method
The script calls client.get_all_orders() on the Polymarket instance, but this method does not exist in the Polymarket class. The Polymarket class has methods like get_all_markets() and get_all_events(), but no get_all_orders() method was ever implemented. The # type: ignore comment suppresses the type checker warning that would have caught this, so the script will crash at runtime with an AttributeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script to fetch all orders via the API and write them to a JSON file, allowing users to archive their trading history.
Note
Adds a new script to export full order history
scripts/python/download_order_history.pyusesPolymarket().get_all_orders()to fetch orders and writes[o.as_dict()]todata/order_history_download.jsonWritten by Cursor Bugbot for commit 48e7668. This will update automatically on new commits. Configure here.