add order history cleanup utility#134
Open
kirito201922 wants to merge 1 commit intoPolymarket:mainfrom
Open
Conversation
Adds a script that prunes closed orders from a local order history JSON, reducing file size and improving performance.
| return | ||
| data = json.loads(HISTORY_PATH.read_text()) | ||
| original_len = len(data.get("orders", [])) | ||
| data["orders"] = [o for o in data.get("orders", []) if o.get("status") != "closed"] |
There was a problem hiding this comment.
Script adds "orders" key to files lacking it
The code unconditionally assigns data["orders"] even when the original JSON file doesn't contain an "orders" key. If run on a file without this key, the script will add "orders": [] to the file structure rather than leaving it unchanged. A cleanup utility probably shouldn't modify files that have no matching data to clean. The logic uses data.get("orders", []) to safely read, but then always writes back via assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script that prunes closed orders from a local order history JSON, reducing file size and improving performance.
Note
Introduces a Python utility to prune closed orders from
data/order_history.jsonto keep history size manageable.scripts/python/clean_order_history.pythat filters out orders withstatus == "closed"and rewrites the JSON (pretty-printed)Written by Cursor Bugbot for commit 5d9270f. This will update automatically on new commits. Configure here.