test: add sample market data fixture#123
Open
mehmetyavuzz43 wants to merge 2 commits intoPolymarket:mainfrom
Open
test: add sample market data fixture#123mehmetyavuzz43 wants to merge 2 commits intoPolymarket:mainfrom
mehmetyavuzz43 wants to merge 2 commits intoPolymarket:mainfrom
Conversation
Provides a .env sanity-check script that validates required variables for Polymarket Agents.
Adds a JSON fixture representing a sample market with realistic fields, to be used in unit tests or examples.
| export "${key}=${value}" | ||
| ;; | ||
| esac | ||
| done < "${ENV_FILE}" |
There was a problem hiding this comment.
Last line of .env skipped without trailing newline
The while IFS='=' read -r key value loop fails to process the last line of the .env file if it doesn't end with a trailing newline. When read encounters EOF without a newline, it returns a non-zero exit status even though it successfully populated the variables, causing the while loop to exit before processing that line. This could silently skip exporting critical environment variables like OPENAI_API_KEY, leading the validation to incorrectly report them as missing. The fix requires adding || [ -n "$key" ] to the while condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a JSON fixture representing a sample market with realistic fields, to be used in unit tests or examples.
Note
Introduces a simple tooling and test fixture addition.
scripts/bash/check_env.shto validate.envpresence and required vars (POLYGON_WALLET_PRIVATE_KEY,OPENAI_API_KEY); exits with error if missing/emptytests/fixtures/sample_market.jsonproviding realistic market data for unit tests/examplesWritten by Cursor Bugbot for commit 07840b6. This will update automatically on new commits. Configure here.