Open
Conversation
kesch9
reviewed
Dec 16, 2025
| } | ||
|
|
||
| public List<TrainingSession> getTrainingSessionsForDayAndTime(DayOfWeek dayOfWeek, TimeOfDay timeOfDay) { | ||
| return timetable.get(dayOfWeek).get(timeOfDay); |
There was a problem hiding this comment.
Если у вас в Map нет записи по dayOfWeek будет ошибка NPE.
Также если нет записи, то нужно вернуть пустой список вместо null
| } | ||
|
|
||
| public Map<TimeOfDay, List<TrainingSession>> getTrainingSessionsForDay(DayOfWeek dayOfWeek) { | ||
| return timetable.get(dayOfWeek); |
There was a problem hiding this comment.
Если записи нет, то вернется null, лучше вернуть пустой список
Owner
Author
|
Извините за дурацкий вопрос. Я запушил изменения в ветку, они отобразились? Или надо новый pull request делать с правками? |
Всё отобразилось, не нужно делать новый PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.