Add cosmic-text as an option for the text renderer#16
Draft
ids1024 wants to merge 1 commit into
Draft
Conversation
889abbe to
469fe18
Compare
Cosmic-text is still changing somewhat rapidly, but should provide a way to handle RTL/bidir/etc text with proper shaping. So I thought I'd try adding support for it here. This isn't quite working right when I try it with Arabic text (maybe partly that it needs alpha blending when compositing glyphs?). And it needs to request the right font.
Contributor
|
Self-requesting review, due to bevyengine/bevy#10193 landing (soon?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmic-text is still changing somewhat rapidly, but should provide a way to handle RTL/bidir/etc text with proper shaping. So I thought I'd try adding support for it here.
This isn't quite working right when I try it with Arabic text (maybe partly that it needs alpha blending when compositing glyphs?). And it needs to request the right font.