Conversation
Huygon764
force-pushed
the
develop
branch
2 times, most recently
from
97f1d52 to
713c2b1
Compare
- Enhanced readability by reformatting import statements and function parameters in `mixer.controller.ts`, `mixer.indexer.ts`, and `mixer.service.ts`. - Added new components for the Mixer UI: `DepositTab`, `WithdrawTab`, `MixerContainer`, and `PoolStats`. - Implemented hooks for managing deposits and withdrawals in `useMixerDeposit` and `useMixerWithdraw`. - Updated DTOs in the shared package to improve type validation. - Introduced new API methods in `mixerApi` for handling deposits and withdrawals.
- Added state management for cached commitments in `WithdrawTab` to optimize withdrawal processes. - Updated `getWithdrawableSlots` in `useMixerWithdraw` to return commitments alongside slots, reducing redundant API calls. - Refactored `useMixerKeys` to utilize refs for base secret management, improving performance during concurrent calls. - Adjusted `useMixerWithdraw` to accept commitments as parameters, streamlining the withdrawal flow.
Huygon764
force-pushed
the
feat/private-transfer
branch
from
4b64cc4 to
0f80cd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Comments (optional)
Allows users to deposit funds into a shared pool and withdraw to a different address with no on-chain link between deposit and withdrawal.
Flow:
Deposit: User → choose token & amount → confirm tx → funds enter Mixer pool (Poseidon commitment stored in on-chain Merkle tree)
Withdraw:
The user's wallet never appears in the withdrawal transaction — a relayer executes it on-chain.
Testing: deposit a fixed amount on Horizen/Base testnet → load deposits on Withdraw tab → select recipient → withdraw → verify funds arrive from the relayer address, not the user's wallet.