fix: deterministic ordering in get_change_logs_for_table (#953)#954
Merged
fix: deterministic ordering in get_change_logs_for_table (#953)#954
Conversation
Closes #953. The change_log query had no ORDER BY, so when an INSERT and a subsequent UPDATE had identical created_at timestamps, their relative order in the result was undefined, causing intermittent CI failures in test_agencies_table_logic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY created_at ASC, id ASCtoDatabaseClient.get_change_logs_for_tableso logs are returned in a deterministic order.tests/test_database.py::test_agencies_table_logicwhere the INSERT and UPDATE rows could be returned in either order when theircreated_attimestamps matched.Closes #953.
Test plan
tests/test_database.py::test_agencies_table_logic🤖 Generated with Claude Code