fix: resolve basedpyright type errors for sqlstate access#946
Merged
Conversation
Use getattr to safely access sqlstate on IntegrityError.orig, which is typed as BaseException but is a psycopg3 exception at runtime. Also add pre-commit checks section to CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostDataSourceQuerywheree.orig.sqlstatewas accessed on aBaseException-typed objectgetattr(e.orig, "sqlstate", None)to safely access the psycopg3-specific attributeCLAUDE.mddocumenting thatbasedpyright --level errorshould be run before committingTest plan
uv run basedpyright --level errorpasses with 0 errors🤖 Generated with Claude Code