Added a PyErr_CheckSignals() call every time we re-aquire the GIL#710
Merged
Conversation
robambalu
requested review from
AdamGlustein,
alexddobkin and
svatasoiu
as code owners
…is is to ensure we process any pending signals even if not calling into python. Also have PyEngine return NULL if there is a pending exception ( ie KeyboardInterrupt ) so that it gets raised on return Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
robambalu
force-pushed
the
rba/signal_check
branch
from
5e7e248 to
6191a5a
Compare
timkpaine
changed the title
arhamchopra
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to ensure we process any pending signals even if not calling into python.
Also have PyEngine return NULL if there is a pending exception ( ie KeyboardInterrupt ) so that it gets raised on return