Skip to content

Add parity tests for model_alias vs bare-string registry aliases#234

Merged
timkpaine merged 2 commits into
nk/auto_deps_auto_callable_modelfrom
tkp/flow-model-bare-string-alias
Jun 9, 2026
Merged

Add parity tests for model_alias vs bare-string registry aliases#234
timkpaine merged 2 commits into
nk/auto_deps_auto_callable_modelfrom
tkp/flow-model-bare-string-alias

Conversation

@timkpaine

Copy link
Copy Markdown
Member

In ccflow a bare string field value already resolves from the model registry, so ccflow.compose.model_alias, a bare-string alias, and a root-relative /name alias should all dereference to the same registered model instance. model_alias is a Hydra convenience for the existing bare-string convention, not a separate mechanism.

Adds a small Hydra config wiring one registered source three equivalent ways and tests asserting all three resolve to the same instance (not a literal string) and compute identically.

In ccflow a bare string field value already resolves from the model registry,
so `ccflow.compose.model_alias`, a bare-string alias, and a root-relative
`/name` alias should all dereference to the same registered model instance.
`model_alias` is a Hydra convenience for the existing bare-string convention,
not a separate mechanism.

Adds a small Hydra config wiring one registered source three equivalent ways
and tests asserting all three resolve to the same instance (not a literal
string) and compute identically.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   2m 58s ⏱️ +8s
1 151 tests +2  1 149 ✅ +2  2 💤 ±0  0 ❌ ±0 
1 157 runs  +2  1 155 ✅ +2  2 💤 ±0  0 ❌ ±0 

Results for commit 55c3ffa. ± Comparison against base commit 91d008b.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (91d008b) to head (55c3ffa).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           nk/auto_deps_auto_callable_model     #234   +/-   ##
=================================================================
  Coverage                             92.98%   92.99%           
=================================================================
  Files                                   158      159    +1     
  Lines                                 17728    17751   +23     
  Branches                               1147     1147           
=================================================================
+ Hits                                  16484    16507   +23     
  Misses                                 1018     1018           
  Partials                                226      226           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timkpaine timkpaine merged commit d11a398 into nk/auto_deps_auto_callable_model Jun 9, 2026
20 checks passed
@timkpaine timkpaine deleted the tkp/flow-model-bare-string-alias branch June 9, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant