Split _build_compute_context into focused per-path helpers#233
Merged
timkpaine merged 1 commit intoJun 9, 2026
Merged
Conversation
`_build_compute_context` mixed argument validation, the explicit-context path, plain-CallableModel defaults, and generated-model handling across one long function with several exit branches. Extract the three paths into `_compute_context_from_explicit`, `_compute_context_for_plain_model`, and `_compute_context_for_generated_model`, leaving `_build_compute_context` as a thin dispatcher. Behavior-preserving refactor; no functional change. Verified against the full flow_model, flow_context, hydra, and evaluator suites. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nk/auto_deps_auto_callable_model #233 +/- ##
====================================================================
- Coverage 93.09% 92.83% -0.26%
====================================================================
Files 158 152 -6
Lines 17895 17360 -535
Branches 1221 1130 -91
====================================================================
- Hits 16660 16117 -543
- Misses 1014 1019 +5
- Partials 221 224 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timkpaine
merged commit 91d008b
into
nk/auto_deps_auto_callable_model
18 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_build_compute_contextmixed argument validation, the explicit-context path, plain-CallableModel defaults, and generated-model handling across one long function with several exit branches. Extract the three paths into_compute_context_from_explicit,_compute_context_for_plain_model, and_compute_context_for_generated_model, leaving_build_compute_contextas a thin dispatcher.Behavior-preserving refactor; no functional change. Verified against the full flow_model, flow_context, hydra, and evaluator suites.